Skip to content

Commit

Permalink
Fixing lease renewal
Browse files Browse the repository at this point in the history
Commit c9fdeb2 removed a 'continue' after checking if the lease needs
to be renewed. However, if client hasn't moved, the code falls down to
starting reboot recovery erroneously (ie., sends open reclaim and gets
back stale_clientid error) before recovering from getting stale_clientid
on the renew operation.

Signed-off-by: Olga Kornievskaia <[email protected]>
Fixes: c9fdeb2 (NFS: Add basic migration support to state manager thread)
Cc: [email protected] # 3.13+
Signed-off-by: Trond Myklebust <[email protected]>
  • Loading branch information
olgakorn1 authored and trondmypd committed Sep 25, 2014
1 parent 5466112 commit 8faaa6d
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions fs/nfs/nfs4state.c
Original file line number Diff line number Diff line change
Expand Up @@ -2345,6 +2345,7 @@ static void nfs4_state_manager(struct nfs_client *clp)
status = nfs4_check_lease(clp);
if (status < 0)
goto out_error;
continue;
}

if (test_and_clear_bit(NFS4CLNT_MOVED, &clp->cl_state)) {
Expand Down

0 comments on commit 8faaa6d

Please sign in to comment.