hwmon: (max31790) potential ERR_PTR dereference

We should only dereference "data" after we check if it is an error pointer. Fixes: 54187ff ('hwmon: (max31790) Convert to use new hwmon registration API') Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: Guenter Roeck <[email protected]>
josf · Oct 17, 2016 · 94cdc56 · 94cdc56
1 parent 667f4ba
commit 94cdc56
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/drivers/hwmon/max31790.c b/drivers/hwmon/max31790.c
@@ -268,11 +268,13 @@ static int max31790_read_pwm(struct device *dev, u32 attr, int channel,
 			     long *val)
 {
 	struct max31790_data *data = max31790_update_device(dev);
-	u8 fan_config = data->fan_config[channel];
+	u8 fan_config;
 
 	if (IS_ERR(data))
 		return PTR_ERR(data);
 
+	fan_config = data->fan_config[channel];
+
 	switch (attr) {
 	case hwmon_pwm_input:
 		*val = data->pwm[channel] >> 8;