pstore: Actually give up during locking failure

Without a return after the pr_err(), dumps will collide when two threads call pstore_dump() at the same time. Signed-off-by: Liu Hailong <[email protected]> Signed-off-by: Li Pengcheng <[email protected]> Signed-off-by: Li Zhong <[email protected]> [kees: improved commit message] Signed-off-by: Kees Cook <[email protected]>
josf · Nov 9, 2016 · 959217c · 959217c
1 parent 07d9a38
commit 959217c
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
@@ -493,6 +493,7 @@ static void pstore_dump(struct kmsg_dumper *dumper,
 		if (!is_locked) {
 			pr_err("pstore dump routine blocked in %s path, may corrupt error record\n"
 				       , in_nmi() ? "NMI" : why);
+			return;
 		}
 	} else {
 		spin_lock_irqsave(&psinfo->buf_lock, flags);