Skip to content

Commit

Permalink
rpmsg: glink-smem: Name the edge based on parent remoteproc
Browse files Browse the repository at this point in the history
Naming the glink edge device on the parent of_node short name causes
collisions when multiple remoteproc instances with only different unit
address are described on the platform_bus in DeviceTree.

Base the edge's name on the parent remoteproc's name instead, to ensure
that it's unique.

Reviewed-by: Niklas Cassel <[email protected]>
Signed-off-by: Bjorn Andersson <[email protected]>
  • Loading branch information
andersson committed Sep 17, 2019
1 parent 61c65f4 commit 9fe69a7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/rpmsg/qcom_glink_smem.c
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ struct qcom_glink *qcom_glink_smem_register(struct device *parent,
dev->parent = parent;
dev->of_node = node;
dev->release = qcom_glink_smem_release;
dev_set_name(dev, "%pOFn:%pOFn", node->parent, node);
dev_set_name(dev, "%s:%pOFn", dev_name(parent->parent), node);
ret = device_register(dev);
if (ret) {
pr_err("failed to register glink edge\n");
Expand Down

0 comments on commit 9fe69a7

Please sign in to comment.