Skip to content

Commit

Permalink
fpga: machxo2-spi: Fix missing error code in machxo2_write_complete()
Browse files Browse the repository at this point in the history
The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'ret'.

Eliminate the follow smatch warning:

drivers/fpga/machxo2-spi.c:341 machxo2_write_complete()
  warn: missing error code 'ret'.

[[email protected]: Reworded commit message]
Fixes: 88fb3a0 ("fpga: lattice machxo2: Add Lattice MachXO2 support")
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
Signed-off-by: Moritz Fischer <[email protected]>
  • Loading branch information
Jiapeng Chong authored and mfischer committed Sep 15, 2021
1 parent 3433173 commit a1e4470
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/fpga/machxo2-spi.c
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,7 @@ static int machxo2_write_complete(struct fpga_manager *mgr,
break;
if (++refreshloop == MACHXO2_MAX_REFRESH_LOOP) {
machxo2_cleanup(mgr);
ret = -EINVAL;
goto fail;
}
} while (1);
Expand Down

0 comments on commit a1e4470

Please sign in to comment.