Skip to content

Commit

Permalink
media: dt-bindings: Convert imx290.txt to YAML
Browse files Browse the repository at this point in the history
Convert the Sony IMX290 DT binding from text to YAML. Add Manivannan as
a maintainer given that he is listed in MAINTAINERS for the file, as
volunteering myself.

The name of the input clock, "xclk", is wrong as the hardware manual
names it INCK. As the device has a single clock, the name could be
omitted, but that would require a corresponding change to the driver and
is thus a candidate for further patches.

Signed-off-by: Laurent Pinchart <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
Signed-off-by: Sakari Ailus <[email protected]>
  • Loading branch information
pinchartl authored and Sakari Ailus committed Oct 27, 2022
1 parent 153e4ad commit a96dfea
Show file tree
Hide file tree
Showing 3 changed files with 130 additions and 58 deletions.
57 changes: 0 additions & 57 deletions Documentation/devicetree/bindings/media/i2c/imx290.txt

This file was deleted.

129 changes: 129 additions & 0 deletions Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,129 @@
# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
%YAML 1.2
---
$id: http://devicetree.org/schemas/media/i2c/sony,imx290.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#

title: Sony IMX290 1/2.8-Inch CMOS Image Sensor

maintainers:
- Manivannan Sadhasivam <[email protected]>
- Laurent Pinchart <[email protected]>

description: |-
The Sony IMX290 is a 1/2.8-Inch CMOS Solid-state image sensor with Square
Pixel for Color Cameras. It is programmable through I2C and 4-wire
interfaces. The sensor output is available via CMOS logic parallel SDR
output, Low voltage LVDS DDR output and CSI-2 serial data output. The CSI-2
bus is the default. No bindings have been defined for the other busses.
properties:
compatible:
enum:
- sony,imx290

reg:
maxItems: 1

clocks:
maxItems: 1

clock-names:
description: Input clock (37.125 MHz or 74.25 MHz)
items:
- const: xclk

clock-frequency:
description: Frequency of the xclk clock in Hz

vdda-supply:
description: Analog power supply (2.9V)

vddd-supply:
description: Digital core power supply (1.2V)

vdddo-supply:
description: Digital I/O power supply (1.8V)

reset-gpios:
description: Sensor reset (XCLR) GPIO
maxItems: 1

port:
$ref: /schemas/graph.yaml#/$defs/port-base
description: |
Video output port
properties:
endpoint:
$ref: /schemas/media/video-interfaces.yaml#
unevaluatedProperties: false

properties:
data-lanes:
anyOf:
- items:
- const: 1
- const: 2
- items:
- const: 1
- const: 2
- const: 3
- const: 4

link-frequencies: true

required:
- data-lanes
- link-frequencies

additionalProperties: false

required:
- compatible
- reg
- clocks
- clock-names
- clock-frequency
- vdda-supply
- vddd-supply
- vdddo-supply
- port

additionalProperties: false

examples:
- |
#include <dt-bindings/gpio/gpio.h>
i2c {
#address-cells = <1>;
#size-cells = <0>;
imx290: camera-sensor@1a {
compatible = "sony,imx290";
reg = <0x1a>;
pinctrl-names = "default";
pinctrl-0 = <&camera_rear_default>;
clocks = <&gcc 90>;
clock-names = "xclk";
clock-frequency = <37125000>;
vdddo-supply = <&camera_vdddo_1v8>;
vdda-supply = <&camera_vdda_2v8>;
vddd-supply = <&camera_vddd_1v5>;
reset-gpios = <&msmgpio 35 GPIO_ACTIVE_LOW>;
port {
imx290_ep: endpoint {
data-lanes = <1 2 3 4>;
link-frequencies = /bits/ 64 <445500000>;
remote-endpoint = <&csiphy0_ep>;
};
};
};
};
...
2 changes: 1 addition & 1 deletion MAINTAINERS
Original file line number Diff line number Diff line change
Expand Up @@ -19207,7 +19207,7 @@ M: Manivannan Sadhasivam <[email protected]>
L: [email protected]
S: Maintained
T: git git://linuxtv.org/media_tree.git
F: Documentation/devicetree/bindings/media/i2c/imx290.txt
F: Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml
F: drivers/media/i2c/imx290.c

SONY IMX319 SENSOR DRIVER
Expand Down

0 comments on commit a96dfea

Please sign in to comment.