Skip to content

Commit

Permalink
MIPS: don't use module_init in non-modular cobalt/mtd.c file
Browse files Browse the repository at this point in the history
As of commit 34b1252 ("MIPS:
Cobalt: Do not build MTD platform device registration code as module.")
this file became built-in instead of modular.  So we should also
stop using module_init as an alias for __initcall as that can be
rather misleading.

Fix this up now, so that we can relocate module_init from
init.h into module.h in the future.  If we don't do this, we'd
have to add module.h to obviously non-modular code, and that
would be a worse thing.

Direct use of __initcall is discouraged, vs prioritized ones.
Use of device_initcall is consistent with what __initcall
maps onto, and hence does not change the init order, making the
impact of this change zero.

Cc: Ralf Baechle <[email protected]>
Cc: [email protected]
Signed-off-by: Paul Gortmaker <[email protected]>
  • Loading branch information
Paul Gortmaker committed Jun 16, 2015
1 parent 33d69ca commit b0c6d93
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions arch/mips/cobalt/mtd.c
Original file line number Diff line number Diff line change
Expand Up @@ -57,5 +57,4 @@ static int __init cobalt_mtd_init(void)

return 0;
}

module_init(cobalt_mtd_init);
device_initcall(cobalt_mtd_init);

0 comments on commit b0c6d93

Please sign in to comment.