Skip to content

Commit

Permalink
mm/memcg: Add folio_lruvec()
Browse files Browse the repository at this point in the history
This replaces mem_cgroup_page_lruvec().  All callers converted.

Signed-off-by: Matthew Wilcox (Oracle) <[email protected]>
Reviewed-by: Christoph Hellwig <[email protected]>
Acked-by: Mike Rapoport <[email protected]>
Reviewed-by: David Howells <[email protected]>
Acked-by: Vlastimil Babka <[email protected]>
  • Loading branch information
Matthew Wilcox (Oracle) committed Sep 27, 2021
1 parent fcce467 commit b1baabd
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 17 deletions.
20 changes: 9 additions & 11 deletions include/linux/memcontrol.h
Original file line number Diff line number Diff line change
Expand Up @@ -784,18 +784,17 @@ static inline struct lruvec *mem_cgroup_lruvec(struct mem_cgroup *memcg,
}

/**
* mem_cgroup_page_lruvec - return lruvec for isolating/putting an LRU page
* @page: the page
* folio_lruvec - return lruvec for isolating/putting an LRU folio
* @folio: Pointer to the folio.
*
* This function relies on page->mem_cgroup being stable.
* This function relies on folio->mem_cgroup being stable.
*/
static inline struct lruvec *mem_cgroup_page_lruvec(struct page *page)
static inline struct lruvec *folio_lruvec(struct folio *folio)
{
pg_data_t *pgdat = page_pgdat(page);
struct mem_cgroup *memcg = page_memcg(page);
struct mem_cgroup *memcg = folio_memcg(folio);

VM_WARN_ON_ONCE_PAGE(!memcg && !mem_cgroup_disabled(), page);
return mem_cgroup_lruvec(memcg, pgdat);
VM_WARN_ON_ONCE_FOLIO(!memcg && !mem_cgroup_disabled(), folio);
return mem_cgroup_lruvec(memcg, folio_pgdat(folio));
}

struct mem_cgroup *mem_cgroup_from_task(struct task_struct *p);
Expand Down Expand Up @@ -1256,10 +1255,9 @@ static inline struct lruvec *mem_cgroup_lruvec(struct mem_cgroup *memcg,
return &pgdat->__lruvec;
}

static inline struct lruvec *mem_cgroup_page_lruvec(struct page *page)
static inline struct lruvec *folio_lruvec(struct folio *folio)
{
pg_data_t *pgdat = page_pgdat(page);

struct pglist_data *pgdat = folio_pgdat(folio);
return &pgdat->__lruvec;
}

Expand Down
2 changes: 1 addition & 1 deletion mm/compaction.c
Original file line number Diff line number Diff line change
Expand Up @@ -1022,7 +1022,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
if (!TestClearPageLRU(page))
goto isolate_fail_put;

lruvec = mem_cgroup_page_lruvec(page);
lruvec = folio_lruvec(page_folio(page));

/* If we already hold the lock, we can skip some rechecking */
if (lruvec != locked) {
Expand Down
9 changes: 6 additions & 3 deletions mm/memcontrol.c
Original file line number Diff line number Diff line change
Expand Up @@ -1154,9 +1154,10 @@ void lruvec_memcg_debug(struct lruvec *lruvec, struct page *page)
*/
struct lruvec *lock_page_lruvec(struct page *page)
{
struct folio *folio = page_folio(page);
struct lruvec *lruvec;

lruvec = mem_cgroup_page_lruvec(page);
lruvec = folio_lruvec(folio);
spin_lock(&lruvec->lru_lock);

lruvec_memcg_debug(lruvec, page);
Expand All @@ -1166,9 +1167,10 @@ struct lruvec *lock_page_lruvec(struct page *page)

struct lruvec *lock_page_lruvec_irq(struct page *page)
{
struct folio *folio = page_folio(page);
struct lruvec *lruvec;

lruvec = mem_cgroup_page_lruvec(page);
lruvec = folio_lruvec(folio);
spin_lock_irq(&lruvec->lru_lock);

lruvec_memcg_debug(lruvec, page);
Expand All @@ -1178,9 +1180,10 @@ struct lruvec *lock_page_lruvec_irq(struct page *page)

struct lruvec *lock_page_lruvec_irqsave(struct page *page, unsigned long *flags)
{
struct folio *folio = page_folio(page);
struct lruvec *lruvec;

lruvec = mem_cgroup_page_lruvec(page);
lruvec = folio_lruvec(folio);
spin_lock_irqsave(&lruvec->lru_lock, *flags);

lruvec_memcg_debug(lruvec, page);
Expand Down
3 changes: 2 additions & 1 deletion mm/swap.c
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,8 @@ void lru_note_cost(struct lruvec *lruvec, bool file, unsigned int nr_pages)

void lru_note_cost_page(struct page *page)
{
lru_note_cost(mem_cgroup_page_lruvec(page),
struct folio *folio = page_folio(page);
lru_note_cost(folio_lruvec(folio),
page_is_file_lru(page), thp_nr_pages(page));
}

Expand Down
3 changes: 2 additions & 1 deletion mm/workingset.c
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,7 @@ void workingset_refault(struct page *page, void *shadow)
*/
void workingset_activation(struct page *page)
{
struct folio *folio = page_folio(page);
struct mem_cgroup *memcg;
struct lruvec *lruvec;

Expand All @@ -411,7 +412,7 @@ void workingset_activation(struct page *page)
memcg = page_memcg_rcu(page);
if (!mem_cgroup_disabled() && !memcg)
goto out;
lruvec = mem_cgroup_page_lruvec(page);
lruvec = folio_lruvec(folio);
workingset_age_nonresident(lruvec, thp_nr_pages(page));
out:
rcu_read_unlock();
Expand Down

0 comments on commit b1baabd

Please sign in to comment.