Skip to content

Commit

Permalink
ext4: don't set i_flags in EXT4_IOC_SETFLAGS
Browse files Browse the repository at this point in the history
Commit 7990696 uses the ext4_{set,clear}_inode_flags() functions to
change the i_flags automatically but fails to remove the error setting
of i_flags.  So we still have the problem of trashing state flags.
Fix this by removing the assignment.

Signed-off-by: Tao Ma <[email protected]>
Signed-off-by: "Theodore Ts'o" <[email protected]>
Cc: [email protected]
  • Loading branch information
taoma-tm authored and tytso committed Jun 7, 2012
1 parent b0dd6b7 commit b22b1f1
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion fs/ext4/ioctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ long ext4_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
else
ext4_clear_inode_flag(inode, i);
}
ei->i_flags = flags;

ext4_set_inode_flags(inode);
inode->i_ctime = ext4_current_time(inode);
Expand Down

0 comments on commit b22b1f1

Please sign in to comment.