Skip to content

Commit

Permalink
[PATCH] autofs4: zero timeout prevents shutdown
Browse files Browse the repository at this point in the history
If the timeout of an autofs mount is set to zero then umounts are disabled.
 This works fine, however the kernel module checks the expire timeout and
goes no further if it is zero.  This is not the right thing to do at
shutdown as the module is passed an option to expire mounts regardless of
their timeout setting.

This patch allows autofs to honor the force expire option.

Signed-off-by: Ian Kent <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
raven-au authored and Linus Torvalds committed Sep 26, 2006
1 parent a6d967a commit c0ba7e5
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions fs/autofs4/expire.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ static inline int autofs4_can_expire(struct dentry *dentry,

if (!do_now) {
/* Too young to die */
if (time_after(ino->last_used + timeout, now))
if (!timeout || time_after(ino->last_used + timeout, now))
return 0;

/* update last_used here :-
Expand Down Expand Up @@ -253,7 +253,7 @@ static struct dentry *autofs4_expire_direct(struct super_block *sb,
struct dentry *root = dget(sb->s_root);
int do_now = how & AUTOFS_EXP_IMMEDIATE;

if (!sbi->exp_timeout || !root)
if (!root)
return NULL;

now = jiffies;
Expand Down Expand Up @@ -293,7 +293,7 @@ static struct dentry *autofs4_expire_indirect(struct super_block *sb,
int do_now = how & AUTOFS_EXP_IMMEDIATE;
int exp_leaves = how & AUTOFS_EXP_LEAVES;

if ( !sbi->exp_timeout || !root )
if (!root)
return NULL;

now = jiffies;
Expand Down

0 comments on commit c0ba7e5

Please sign in to comment.