selinux: Fix error return code in sel_ib_pkey_sid_slow()

Fix to return a negative error code from the error handling case instead of 0 in function sel_ib_pkey_sid_slow(), as done elsewhere in this function. Cc: [email protected] Fixes: 409dcf3 ("selinux: Add a cache for quicker retreival of PKey SIDs") Reported-by: Hulk Robot <[email protected]> Signed-off-by: Chen Zhou <[email protected]> Signed-off-by: Paul Moore <[email protected]>
josf · Nov 13, 2020 · c350f8b · c350f8b
1 parent 0d50f05
commit c350f8b
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/security/selinux/ibpkey.c b/security/selinux/ibpkey.c
@@ -151,8 +151,10 @@ static int sel_ib_pkey_sid_slow(u64 subnet_prefix, u16 pkey_num, u32 *sid)
 	 * is valid, it just won't be added to the cache.
 	 */
 	new = kzalloc(sizeof(*new), GFP_ATOMIC);
-	if (!new)
+	if (!new) {
+		ret = -ENOMEM;
 		goto out;
+	}
 
 	new->psec.subnet_prefix = subnet_prefix;
 	new->psec.pkey = pkey_num;