Skip to content

Commit

Permalink
[PATCH] fbcon/fbdev: Move softcursor out of fbdev to fbcon
Browse files Browse the repository at this point in the history
According to Jon Smirl, filling in the field fb_cursor with soft_cursor for
drivers that do not support hardware cursors is redundant.  The soft_cursor
function is usable by all drivers because it is just a wrapper around
fb_imageblit.  And because soft_cursor is an fbcon-specific hook, the file is
moved to the console directory.

Thus, drivers that do not support hardware cursors can leave the fb_cursor
field blank.  For drivers that do, they can fill up this field with their own
version.

The end result is a smaller code size.  And if the framebuffer console is not
loaded, module/kernel size is also reduced because the soft_cursor module will
also not be loaded.

Signed-off-by: Antonino Daplas <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
adaplas authored and Linus Torvalds committed Nov 7, 2005
1 parent e764a20 commit c465e05
Show file tree
Hide file tree
Showing 75 changed files with 20 additions and 162 deletions.
1 change: 0 additions & 1 deletion drivers/video/68328fb.c
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,6 @@ static struct fb_ops mc68x328fb_ops = {
.fb_fillrect = cfb_fillrect,
.fb_copyarea = cfb_copyarea,
.fb_imageblit = cfb_imageblit,
.fb_cursor = soft_cursor,
.fb_mmap = mc68x328fb_mmap,
};

Expand Down
Loading

0 comments on commit c465e05

Please sign in to comment.