Skip to content

Commit

Permalink
cifs: bugfix for unreclaimed writeback pages in cifs_writev_requeue()
Browse files Browse the repository at this point in the history
Pages get the PG_writeback flag set before cifs sends its
request to SMB server in cifs_writepages(), if the SMB service
goes down, cifs may try to recommit the writing requests in
cifs_writev_requeue(). However, it does not clean its PG_writeback
flag and relaimed the pages even if it fails again in
cifs_writev_requeue(), which may lead to the hanging of the
processes accessing the cifs directory. This patch just cleans
the PG_writeback flags and reclaims the pages under that circumstances.

    Steps to reproduce the bug(trying serveral times may trigger the issue):
    1.Write from cifs client continuously.(e.g dd if=/dev/zero of=<cifs file>)
    2.Stop SMB service from server.(e.g service smb stop)
    3.Wait for two minutes, and then start SMB service from
server.(e.g service smb start)
    4.The processes which are accessing cifs directory may hang up.

Signed-off-by: Ouyang Maochun <[email protected]>
Signed-off-by: Jiang Yong <[email protected]>
Tested-by: Zhang Xianwei <[email protected]>
Reviewed-by: Wang Liang <[email protected]>
Reviewed-by: Cai Qu <[email protected]>
Reviewed-by: Jiang Biao <[email protected]>
Reviewed-by: Jeff Layton <[email protected]>
Reviewed-by: Pavel Shilovsky <[email protected]>
Signed-off-by: Steve French <[email protected]>
  • Loading branch information
Ouyang Maochun authored and Steve French committed Feb 28, 2013
1 parent 0b7bc84 commit c51bb0e
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion fs/cifs/cifssmb.c
Original file line number Diff line number Diff line change
Expand Up @@ -1909,8 +1909,11 @@ cifs_writev_requeue(struct cifs_writedata *wdata)
} while (rc == -EAGAIN);

for (i = 0; i < wdata->nr_pages; i++) {
if (rc != 0)
if (rc != 0) {
SetPageError(wdata->pages[i]);
end_page_writeback(wdata->pages[i]);
page_cache_release(wdata->pages[i]);
}
unlock_page(wdata->pages[i]);
}

Expand Down

0 comments on commit c51bb0e

Please sign in to comment.