Skip to content

Commit

Permalink
net: skge: convert tasklets to use new tasklet_setup() API
Browse files Browse the repository at this point in the history
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.

Signed-off-by: Romain Perier <[email protected]>
Signed-off-by: Allen Pais <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
allenpais authored and davem330 committed Sep 14, 2020
1 parent 4d07f7e commit cd002b5
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/net/ethernet/marvell/skge.c
Original file line number Diff line number Diff line change
Expand Up @@ -3338,9 +3338,9 @@ static void skge_error_irq(struct skge_hw *hw)
* because accessing phy registers requires spin wait which might
* cause excess interrupt latency.
*/
static void skge_extirq(unsigned long arg)
static void skge_extirq(struct tasklet_struct *t)
{
struct skge_hw *hw = (struct skge_hw *) arg;
struct skge_hw *hw = from_tasklet(hw, t, phy_task);
int port;

for (port = 0; port < hw->ports; port++) {
Expand Down Expand Up @@ -3927,7 +3927,7 @@ static int skge_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
hw->pdev = pdev;
spin_lock_init(&hw->hw_lock);
spin_lock_init(&hw->phy_lock);
tasklet_init(&hw->phy_task, skge_extirq, (unsigned long) hw);
tasklet_setup(&hw->phy_task, skge_extirq);

hw->regs = ioremap(pci_resource_start(pdev, 0), 0x4000);
if (!hw->regs) {
Expand Down

0 comments on commit cd002b5

Please sign in to comment.