Skip to content

Commit

Permalink
ARM: fix PTRACE_SETVFPREGS on SMP systems
Browse files Browse the repository at this point in the history
PTRACE_SETVFPREGS fails to properly mark the VFP register set to be
reloaded, because it undoes one of the effects of vfp_flush_hwstate().

Specifically vfp_flush_hwstate() sets thread->vfpstate.hard.cpu to
an invalid CPU number, but vfp_set() overwrites this with the original
CPU number, thereby rendering the hardware state as apparently "valid",
even though the software state is more recent.

Fix this by reverting the previous change.

Cc: <[email protected]>
Fixes: 8130b9d ("ARM: 7308/1: vfp: flush thread hwstate before copying ptrace registers")
Acked-by: Will Deacon <[email protected]>
Tested-by: Simon Marchi <[email protected]>
Signed-off-by: Russell King <[email protected]>
  • Loading branch information
Russell King committed Jun 2, 2016
1 parent ec953b7 commit e2dfb4b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/arm/kernel/ptrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -733,8 +733,8 @@ static int vfp_set(struct task_struct *target,
if (ret)
return ret;

vfp_flush_hwstate(thread);
thread->vfpstate.hard = new_vfp;
vfp_flush_hwstate(thread);

return 0;
}
Expand Down

0 comments on commit e2dfb4b

Please sign in to comment.