Skip to content

Commit

Permalink
get rid of pointless checks after simple_pin_fs()
Browse files Browse the repository at this point in the history
if we'd just got success from it, vfsmount won't be NULL

Signed-off-by: Al Viro <[email protected]>
  • Loading branch information
Al Viro committed Jan 27, 2010
1 parent 5998649 commit ef52c75
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 18 deletions.
11 changes: 2 additions & 9 deletions fs/debugfs/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -160,15 +160,8 @@ static int debugfs_create_by_name(const char *name, mode_t mode,
* block. A pointer to that is in the struct vfsmount that we
* have around.
*/
if (!parent) {
if (debugfs_mount && debugfs_mount->mnt_sb) {
parent = debugfs_mount->mnt_sb->s_root;
}
}
if (!parent) {
pr_debug("debugfs: Ah! can not find a parent!\n");
return -EFAULT;
}
if (!parent)
parent = debugfs_mount->mnt_sb->s_root;

*dentry = NULL;
mutex_lock(&parent->d_inode->i_mutex);
Expand Down
11 changes: 2 additions & 9 deletions security/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -156,15 +156,8 @@ static int create_by_name(const char *name, mode_t mode,
* block. A pointer to that is in the struct vfsmount that we
* have around.
*/
if (!parent ) {
if (mount && mount->mnt_sb) {
parent = mount->mnt_sb->s_root;
}
}
if (!parent) {
pr_debug("securityfs: Ah! can not find a parent!\n");
return -EFAULT;
}
if (!parent)
parent = mount->mnt_sb->s_root;

mutex_lock(&parent->d_inode->i_mutex);
*dentry = lookup_one_len(name, parent, strlen(name));
Expand Down

0 comments on commit ef52c75

Please sign in to comment.