Skip to content

Commit

Permalink
[IPV4]: Remove suprious use of goto out: in icmp_reply
Browse files Browse the repository at this point in the history
This seems to be an artifact of the follwoing commit in February '02.

e7e173a

In a nutshell, goto out and return actually do the same thing,
and both are called in this function. This patch removes out.

Signed-Off-By: Horms <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
horms authored and davem330 committed Feb 3, 2006
1 parent 95f7daf commit f00c401
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions net/ipv4/icmp.c
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ static void icmp_reply(struct icmp_bxm *icmp_param, struct sk_buff *skb)
u32 daddr;

if (ip_options_echo(&icmp_param->replyopts, skb))
goto out;
return;

if (icmp_xmit_lock())
return;
Expand Down Expand Up @@ -416,7 +416,6 @@ static void icmp_reply(struct icmp_bxm *icmp_param, struct sk_buff *skb)
ip_rt_put(rt);
out_unlock:
icmp_xmit_unlock();
out:;
}


Expand Down

0 comments on commit f00c401

Please sign in to comment.