Skip to content

Commit

Permalink
jbd2: remove unused waitqueues
Browse files Browse the repository at this point in the history
j_wait_logspace and j_wait_checkpoint are unused.  Remove them.

Reviewed-by: Zheng Liu <[email protected]>
Signed-off-by: Jan Kara <[email protected]>
Signed-off-by: "Theodore Ts'o" <[email protected]>
  • Loading branch information
jankara authored and tytso committed Jun 4, 2013
1 parent fe1e8db commit f29fad7
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 14 deletions.
4 changes: 0 additions & 4 deletions fs/jbd2/checkpoint.c
Original file line number Diff line number Diff line change
Expand Up @@ -625,10 +625,6 @@ int __jbd2_journal_remove_checkpoint(struct journal_head *jh)

__jbd2_journal_drop_transaction(journal, transaction);
jbd2_journal_free_transaction(transaction);

/* Just in case anybody was waiting for more transactions to be
checkpointed... */
wake_up(&journal->j_wait_logspace);
ret = 1;
out:
return ret;
Expand Down
2 changes: 0 additions & 2 deletions fs/jbd2/journal.c
Original file line number Diff line number Diff line change
Expand Up @@ -1027,9 +1027,7 @@ static journal_t * journal_init_common (void)
return NULL;

init_waitqueue_head(&journal->j_wait_transaction_locked);
init_waitqueue_head(&journal->j_wait_logspace);
init_waitqueue_head(&journal->j_wait_done_commit);
init_waitqueue_head(&journal->j_wait_checkpoint);
init_waitqueue_head(&journal->j_wait_commit);
init_waitqueue_head(&journal->j_wait_updates);
mutex_init(&journal->j_barrier);
Expand Down
8 changes: 0 additions & 8 deletions include/linux/jbd2.h
Original file line number Diff line number Diff line change
Expand Up @@ -687,9 +687,7 @@ jbd2_time_diff(unsigned long start, unsigned long end)
* waiting for checkpointing
* @j_wait_transaction_locked: Wait queue for waiting for a locked transaction
* to start committing, or for a barrier lock to be released
* @j_wait_logspace: Wait queue for waiting for checkpointing to complete
* @j_wait_done_commit: Wait queue for waiting for commit to complete
* @j_wait_checkpoint: Wait queue to trigger checkpointing
* @j_wait_commit: Wait queue to trigger commit
* @j_wait_updates: Wait queue to wait for updates to complete
* @j_checkpoint_mutex: Mutex for locking against concurrent checkpoints
Expand Down Expand Up @@ -794,15 +792,9 @@ struct journal_s
*/
wait_queue_head_t j_wait_transaction_locked;

/* Wait queue for waiting for checkpointing to complete */
wait_queue_head_t j_wait_logspace;

/* Wait queue for waiting for commit to complete */
wait_queue_head_t j_wait_done_commit;

/* Wait queue to trigger checkpointing */
wait_queue_head_t j_wait_checkpoint;

/* Wait queue to trigger commit */
wait_queue_head_t j_wait_commit;

Expand Down

0 comments on commit f29fad7

Please sign in to comment.