Skip to content

Commit

Permalink
csky: Fixup CONFIG_DEBUG_RSEQ
Browse files Browse the repository at this point in the history
Put the rseq_syscall check point at the prologue of the syscall
will break the a0 ... a7. This will casue system call bug when
DEBUG_RSEQ is enabled.

So move it to the epilogue of syscall, but before syscall_trace.

Signed-off-by: Guo Ren <[email protected]>
  • Loading branch information
guoren83 committed May 28, 2020
1 parent 20f6953 commit f36e0aa
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions arch/csky/kernel/entry.S
Original file line number Diff line number Diff line change
Expand Up @@ -128,15 +128,11 @@ tlbop_end 1
ENTRY(csky_systemcall)
SAVE_ALL TRAP0_SIZE
zero_fp
#ifdef CONFIG_RSEQ_DEBUG
mov a0, sp
jbsr rseq_syscall
#endif
psrset ee, ie

lrw r9, __NR_syscalls
cmphs syscallid, r9 /* Check nr of syscall */
bt ret_from_exception
bt 1f

lrw r9, sys_call_table
ixw r9, syscallid
Expand All @@ -162,6 +158,11 @@ ENTRY(csky_systemcall)
jsr syscallid
#endif
stw a0, (sp, LSAVE_A0) /* Save return value */
1:
#ifdef CONFIG_DEBUG_RSEQ
mov a0, sp
jbsr rseq_syscall
#endif
jmpi ret_from_exception

csky_syscall_trace:
Expand All @@ -187,6 +188,10 @@ csky_syscall_trace:
#endif
stw a0, (sp, LSAVE_A0) /* Save return value */

#ifdef CONFIG_DEBUG_RSEQ
mov a0, sp
jbsr rseq_syscall
#endif
mov a0, sp /* right now, sp --> pt_regs */
jbsr syscall_trace_exit
br ret_from_exception
Expand Down

0 comments on commit f36e0aa

Please sign in to comment.