Skip to content

Commit

Permalink
sh: fix smp_store_mb for !SMP
Browse files Browse the repository at this point in the history
sh variant of smp_store_mb() calls xchg() on !SMP which is stronger than
implied by both the name and the documentation.

commit 90a3ccb ("sh: define __smp_xxx,
fix smp_store_mb for !SMP") was supposed to fix it but
left the bug in place.

Drop smp_store_mb, so that code in asm-generic/barrier.h
will define it correctly depending on CONFIG_SMP.

Signed-off-by: Michael S. Tsirkin <[email protected]>
  • Loading branch information
mstsirkin committed Jan 26, 2016
1 parent a7c4903 commit fb9b050
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion arch/sh/include/asm/barrier.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
#endif

#define __smp_store_mb(var, value) do { (void)xchg(&var, value); } while (0)
#define smp_store_mb(var, value) __smp_store_mb(var, value)

#include <asm-generic/barrier.h>

Expand Down

0 comments on commit fb9b050

Please sign in to comment.