Skip to content

Commit

Permalink
Make specs run faster
Browse files Browse the repository at this point in the history
  $ rspec spec/paperclip/integration_spec.rb --profile 1
  Testing against version 4.1.7
  ..................................

  Finished in 15.19 seconds (files took 0.60155 seconds to load)
  34 examples, 0 failures

  Top 1 slowest examples (9.54 seconds, 62.8% of total time):
    Paperclip Many models at once does not exceed the open file limit
      9.54 seconds ./spec/paperclip/integration_spec.rb:18

to

  $ rspec spec/paperclip/integration_spec.rb --profile 1
  Testing against version 4.1.7
  ..................................

  Finished in 10.95 seconds (files took 0.59585 seconds to load)
  34 examples, 0 failures

  Top 1 slowest examples (5.33 seconds, 48.7% of total time):
    Paperclip Many models at once does not exceed the open file limit
      5.33 seconds ./spec/paperclip/integration_spec.rb:18

Updates gemfiles to Ruby 2 hash syntax.

[closes thoughtbot#1700]
  • Loading branch information
soramugi authored and tute committed Sep 11, 2015
1 parent 3226ab4 commit 1109002
Show file tree
Hide file tree
Showing 12 changed files with 33 additions and 21 deletions.
1 change: 1 addition & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ gem 'pry'
# Hinting at development dependencies
# Prevents bundler from taking a long-time to resolve
group :development, :test do
gem 'activerecord-import'
gem 'mime-types', '~> 1.16'
gem 'builder'
gem 'rubocop', require: false
Expand Down
5 changes: 3 additions & 2 deletions gemfiles/3.2.awsv1.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,16 @@

source "https://rubygems.org"

gem "sqlite3", "~> 1.3.8", :platforms => :ruby
gem "sqlite3", "~> 1.3.8", platforms: :ruby
gem "pry"
gem "rails", "~> 3.2.0"
gem "aws-sdk", "~> 1.5"

group :development, :test do
gem "activerecord-import"
gem "mime-types", "~> 1.16"
gem "builder"
gem "rubocop", :require => false
end

gemspec :path => "../"
gemspec path: "../"
5 changes: 3 additions & 2 deletions gemfiles/3.2.awsv2.0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,16 @@

source "https://rubygems.org"

gem "sqlite3", "~> 1.3.8", :platforms => :ruby
gem "sqlite3", "~> 1.3.8", platforms: :ruby
gem "pry"
gem "rails", "~> 3.2.0"
gem "aws-sdk", "~> 2.0.0"

group :development, :test do
gem "activerecord-import"
gem "mime-types", "~> 1.16"
gem "builder"
gem "rubocop", :require => false
end

gemspec :path => "../"
gemspec path: "../"
5 changes: 3 additions & 2 deletions gemfiles/3.2.awsv2.1.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,16 @@

source "https://rubygems.org"

gem "sqlite3", "~> 1.3.8", :platforms => :ruby
gem "sqlite3", "~> 1.3.8", platforms: :ruby
gem "pry"
gem "rails", "~> 3.2.0"
gem "aws-sdk", "~> 2.1.0"

group :development, :test do
gem "activerecord-import"
gem "mime-types", "~> 1.16"
gem "builder"
gem "rubocop", :require => false
end

gemspec :path => "../"
gemspec path: "../"
5 changes: 3 additions & 2 deletions gemfiles/4.1.awsv1.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,16 @@

source "https://rubygems.org"

gem "sqlite3", "~> 1.3.8", :platforms => :ruby
gem "sqlite3", "~> 1.3.8", platforms: :ruby
gem "pry"
gem "rails", "~> 4.1.0"
gem "aws-sdk", "~> 1.5"

group :development, :test do
gem "activerecord-import"
gem "mime-types", "~> 1.16"
gem "builder"
gem "rubocop", :require => false
end

gemspec :path => "../"
gemspec path: "../"
5 changes: 3 additions & 2 deletions gemfiles/4.1.awsv2.0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,16 @@

source "https://rubygems.org"

gem "sqlite3", "~> 1.3.8", :platforms => :ruby
gem "sqlite3", "~> 1.3.8", platforms: :ruby
gem "pry"
gem "rails", "~> 4.1.0"
gem "aws-sdk", "~> 2.0.0"

group :development, :test do
gem "activerecord-import"
gem "mime-types", "~> 1.16"
gem "builder"
gem "rubocop", :require => false
end

gemspec :path => "../"
gemspec path: "../"
5 changes: 3 additions & 2 deletions gemfiles/4.1.awsv2.1.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,16 @@

source "https://rubygems.org"

gem "sqlite3", "~> 1.3.8", :platforms => :ruby
gem "sqlite3", "~> 1.3.8", platforms: :ruby
gem "pry"
gem "rails", "~> 4.1.0"
gem "aws-sdk", "~> 2.1.0"

group :development, :test do
gem "activerecord-import"
gem "mime-types", "~> 1.16"
gem "builder"
gem "rubocop", :require => false
end

gemspec :path => "../"
gemspec path: "../"
5 changes: 3 additions & 2 deletions gemfiles/4.2.awsv1.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,16 @@

source "https://rubygems.org"

gem "sqlite3", "~> 1.3.8", :platforms => :ruby
gem "sqlite3", "~> 1.3.8", platforms: :ruby
gem "pry"
gem "rails", "~> 4.2.0"
gem "aws-sdk", "~> 1.5"

group :development, :test do
gem "activerecord-import"
gem "mime-types", "~> 1.16"
gem "builder"
gem "rubocop", :require => false
end

gemspec :path => "../"
gemspec path: "../"
5 changes: 3 additions & 2 deletions gemfiles/4.2.awsv2.0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,16 @@

source "https://rubygems.org"

gem "sqlite3", "~> 1.3.8", :platforms => :ruby
gem "sqlite3", "~> 1.3.8", platforms: :ruby
gem "pry"
gem "rails", "~> 4.2.0"
gem "aws-sdk", "~> 2.0.0"

group :development, :test do
gem "activerecord-import"
gem "mime-types", "~> 1.16"
gem "builder"
gem "rubocop", :require => false
end

gemspec :path => "../"
gemspec path: "../"
5 changes: 3 additions & 2 deletions gemfiles/4.2.awsv2.1.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,16 @@

source "https://rubygems.org"

gem "sqlite3", "~> 1.3.8", :platforms => :ruby
gem "sqlite3", "~> 1.3.8", platforms: :ruby
gem "pry"
gem "rails", "~> 4.2.0"
gem "aws-sdk", "~> 2.1.0"

group :development, :test do
gem "activerecord-import"
gem "mime-types", "~> 1.16"
gem "builder"
gem "rubocop", :require => false
end

gemspec :path => "../"
gemspec path: "../"
7 changes: 4 additions & 3 deletions spec/paperclip/integration_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,10 @@
before do
rebuild_model
@file = File.new(fixture_file("5k.png"), 'rb')
300.times do |i|
Dummy.create! avatar: @file
end
# Deals with `Too many open files` error
Dummy.import 100.times.map { Dummy.new avatar: @file }
Dummy.import 100.times.map { Dummy.new avatar: @file }
Dummy.import 100.times.map { Dummy.new avatar: @file }
end

after { @file.close }
Expand Down
1 change: 1 addition & 0 deletions spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
require 'bourne'
require 'ostruct'
require 'pathname'
require 'activerecord-import'

ROOT = Pathname(File.expand_path(File.join(File.dirname(__FILE__), '..')))

Expand Down

0 comments on commit 1109002

Please sign in to comment.