forked from pantsbuild/pants
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add [buf] config and config_discovery options (pantsbuild#17885)
Enhancement for issue [17871](pantsbuild#17871). Add `config` and `config_discovery` options for Buf backend. Documentation pieces to be added to [buf options](https://www.pantsbuild.org/docs/reference-buf): * configuration file is for `lint`, `build` and `breaking` Buf commands. Right now, only `lint` is enabled in Pants backend. There's no configuration file need for `format` command. * the broader option `lint_args` may also contain a `--config something` entry. As placed in this order (config args then lint_args config), the second overrides the first * Buf recommends to have the config within the folder where the protos are located. Discovery is impossible there, as the proto folders would not be known by pants, we should recommend to either have the config file where pants.toml is located, or specify the file path using `[buf].config` Tests: * [X] added integration tests for lint run (1 for config discovery, 1 for specific config file) * [X] local integration test with [running-pants-from-sources-in-other-repos](https://www.pantsbuild.org/v2.15/docs/running-pants-from-sources#running-pants-from-sources-in-other-repos)
- Loading branch information
Showing
3 changed files
with
108 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters