Skip to content

Commit

Permalink
Undo pyenv install marking files as RO (pantsbuild#19645)
Browse files Browse the repository at this point in the history
Fixes pantsbuild#19515

The original change was a precaution to ensure the cached environment
was read-only, but as the ticket points out this makes cache-wiping a
headache and it isn't clear marking as read-only gains us anything.
  • Loading branch information
thejcannon authored Aug 22, 2023
1 parent 494c6f9 commit 54f94da
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/python/pants/backend/python/providers/pyenv/rules.py
Original file line number Diff line number Diff line change
Expand Up @@ -187,10 +187,6 @@ def main():
shutil.rmtree(SPECIFIC_VERSION_PATH, ignore_errors=True)
subprocess.run(["{pyenv.exe}", "install", SPECIFIC_VERSION], check=True)
# Removing write perms helps ensure users aren't accidentally modifying
# Python or the site-packages
subprocess.run(["chmod", "-R", "-w", str(SPECIFIC_VERSION_PATH)], check=True)
subprocess.run(["chmod", "+w", str(SPECIFIC_VERSION_PATH)], check=True)
DONEFILE_PATH.touch()
if __name__ == "__main__":
Expand Down

0 comments on commit 54f94da

Please sign in to comment.