Skip to content

Commit

Permalink
Merge pull request numpy#24479 from seiko2plus/ci_qemu_meson
Browse files Browse the repository at this point in the history
CI: Implements Cross-Compile Builds for armhf, ppc64le, and s390x
  • Loading branch information
mattip authored Aug 24, 2023
2 parents 050dbc6 + f012f1d commit c2051fd
Show file tree
Hide file tree
Showing 2 changed files with 149 additions and 0 deletions.
147 changes: 147 additions & 0 deletions .github/workflows/linux_qemu.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,147 @@
# Meson's Python module doesn't support crosscompiling,
# and python dependencies may be another potential hurdle.
# There might also be a need to run runtime tests during configure time.
#
# The recommended practice is to rely on Docker to provide the x86_64 crosscompile toolchain,
# enabling native execution via binfmt.
#
# In simpler terms, everything except the crosscompile toolchain will be emulated.

name: Linux Qemu tests

on:
pull_request:
branches:
- main
- maintenance/**

defaults:
run:
shell: bash

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

jobs:
linux_qemu:
if: "github.repository == 'numpy/numpy'"
runs-on: ubuntu-22.04
continue-on-error: true
strategy:
matrix:
BUILD_PROP:
- [
"armhf",
"arm-linux-gnueabihf",
"arm32v7/ubuntu:22.04",
"-Dallow-noblas=true",
# test_unary_spurious_fpexception is currently skipped
# FIXME(@seiko2plus): Requires confirmation for the following issue:
# The presence of an FP invalid exception caused by sqrt. Unsure if this is a qemu bug or not.
"(test_kind or test_multiarray or test_simd or test_umath or test_ufunc) and not test_unary_spurious_fpexception"
]
- [
"ppc64le",
"powerpc64le-linux-gnu",
"ppc64le/ubuntu:22.04",
"-Dallow-noblas=true",
"test_kind or test_multiarray or test_simd or test_umath or test_ufunc",
]
- [
"s390x",
"s390x-linux-gnu",
"s390x/ubuntu:22.04",
"-Dallow-noblas=true",
# Skipping TestRationalFunctions.test_gcd_overflow test
# because of a possible qemu bug that appears to be related to int64 overflow in absolute operation.
# TODO(@seiko2plus): Confirm the bug and provide a minimal reproducer, then report it to upstream.
"(test_kind or test_multiarray or test_simd or test_umath or test_ufunc) and not test_gcd_overflow"
]
- [
"s390x - baseline(Z13)",
"s390x-linux-gnu",
"s390x/ubuntu:22.04",
"-Dallow-noblas=true -Dcpu-baseline=vx",
"(test_kind or test_multiarray or test_simd or test_umath or test_ufunc) and not test_gcd_overflow"
]
env:
TOOLCHAIN_NAME: ${{ matrix.BUILD_PROP[1] }}
DOCKER_CONTAINER: ${{ matrix.BUILD_PROP[2] }}
MESON_OPTIONS: ${{ matrix.BUILD_PROP[3] }}
RUNTIME_TEST_FILTER: ${{ matrix.BUILD_PROP[4] }}
TERM: xterm-256color

name: "${{ matrix.BUILD_PROP[0] }}"
steps:
- uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
with:
submodules: recursive
fetch-depth: 0

- name: Initialize binfmt_misc for qemu-user-static
run: |
docker run --rm --privileged multiarch/qemu-user-static --reset -p yes
- name: Install GCC cross-compilers
run: |
sudo apt update
sudo apt install -y ninja-build gcc-${TOOLCHAIN_NAME} g++-${TOOLCHAIN_NAME} gfortran-${TOOLCHAIN_NAME}
- name: Cache docker container
uses: actions/cache@v3
id: container-cache
with:
path: ~/docker_${{ matrix.BUILD_PROP[1] }}
key: container-${{ runner.os }}-${{ matrix.BUILD_PROP[1] }}-${{ matrix.BUILD_PROP[2] }}-${{ hashFiles('build_requirements.txt') }}

- name: Creates new container
if: steps.container-cache.outputs.cache-hit != 'true'
run: |
docker run --name the_container --interactive -v /:/host -v $(pwd):/numpy ${DOCKER_CONTAINER} /bin/bash -c "
apt update &&
apt install -y cmake git python3 python-is-python3 python3-dev python3-pip &&
mkdir -p /lib64 && ln -s /host/lib64/ld-* /lib64/ &&
ln -s /host/lib/x86_64-linux-gnu /lib/x86_64-linux-gnu &&
rm -rf /usr/${TOOLCHAIN_NAME} && ln -s /host/usr/${TOOLCHAIN_NAME} /usr/${TOOLCHAIN_NAME} &&
rm -rf /usr/lib/gcc/${TOOLCHAIN_NAME} && ln -s /host/usr/lib/gcc-cross/${TOOLCHAIN_NAME} /usr/lib/gcc/${TOOLCHAIN_NAME} &&
rm -f /usr/bin/gcc && ln -s /host/usr/bin/${TOOLCHAIN_NAME}-gcc /usr/bin/gcc &&
rm -f /usr/bin/g++ && ln -s /host/usr/bin/${TOOLCHAIN_NAME}-g++ /usr/bin/g++ &&
rm -f /usr/bin/gfortran && ln -s /host/usr/bin/${TOOLCHAIN_NAME}-gfortran /usr/bin/gfortran &&
rm -f /usr/bin/ar && ln -s /host/usr/bin/${TOOLCHAIN_NAME}-ar /usr/bin/ar &&
rm -f /usr/bin/as && ln -s /host/usr/bin/${TOOLCHAIN_NAME}-as /usr/bin/as &&
rm -f /usr/bin/ld && ln -s /host/usr/bin/${TOOLCHAIN_NAME}-ld /usr/bin/ld &&
rm -f /usr/bin/ld.bfd && ln -s /host/usr/bin/${TOOLCHAIN_NAME}-ld.bfd /usr/bin/ld.bfd &&
rm -f /usr/bin/ninja && ln -s /host/usr/bin/ninja /usr/bin/ninja &&
git config --global --add safe.directory /numpy &&
python -m pip install -r /numpy/build_requirements.txt &&
python -m pip install pytest pytest-xdist hypothesis typing_extensions &&
rm -f /usr/local/bin/ninja && mkdir -p /usr/local/bin && ln -s /host/usr/bin/ninja /usr/local/bin/ninja
"
docker commit the_container the_container
mkdir -p "~/docker_${TOOLCHAIN_NAME}"
docker save -o "~/docker_${TOOLCHAIN_NAME}/the_container.tar" the_container
- name: Load container from cache
if: steps.container-cache.outputs.cache-hit == 'true'
run: docker load -i "~/docker_${TOOLCHAIN_NAME}/the_container.tar"

- name: Meson Build
run: |
docker run --rm -e "TERM=xterm-256color" -v $(pwd):/numpy -v /:/host the_container \
/bin/script -e -q -c "/bin/bash --noprofile --norc -eo pipefail -c '
cd /numpy && spin build --clean -- ${MESON_OPTIONS}
'"
- name: Meson Log
if: always()
run: 'cat build/meson-logs/meson-log.txt'

- name: Run Tests
run: |
docker run --rm -e "TERM=xterm-256color" -v $(pwd):/numpy -v /:/host the_container \
/bin/script -e -q -c "/bin/bash --noprofile --norc -eo pipefail -c '
export F90=/usr/bin/gfortran
cd /numpy && spin test -- -k \"${RUNTIME_TEST_FILTER}\"
'"
2 changes: 2 additions & 0 deletions numpy/core/tests/test_simd_module.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ def test_signed_overflow(self, sfx):
assert lanes == [0] * nlanes

def test_truncate_f32(self):
if not npyv.simd_f32:
pytest.skip("F32 isn't support by the SIMD extension")
f32 = npyv.setall_f32(0.1)[0]
assert f32 != 0.1
assert round(f32, 1) == 0.1
Expand Down

0 comments on commit c2051fd

Please sign in to comment.