Skip to content

Commit

Permalink
Use is_expression_type in pass_single_value for consistency
Browse files Browse the repository at this point in the history
  • Loading branch information
gseastream committed Aug 6, 2018
1 parent d3d58c2 commit dfbb6e6
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions pyomo/network/decomposition.py
Original file line number Diff line number Diff line change
Expand Up @@ -463,8 +463,7 @@ def load_values(self, port, default, fixed, use_guesses):
self.combine_and_fix(port, name, obj, evars, fixed)
else:
if obj.is_expression_type():
for var in identify_variables(obj,
include_fixed=False):
for var in identify_variables(obj, include_fixed=False):
self.check_value_fix(port, var, default, fixed,
use_guesses)
else:
Expand Down Expand Up @@ -521,10 +520,7 @@ def pass_single_value(self, port, name, member, val, fixed):
"Member '%s' of port '%s' is already fixed but has a "
"different value (by > %s) than what is being passed to it"
% (name, port.name, eq_tol))
elif member.is_variable_type():
fixed.add(member)
member.fix(val)
else:
elif member.is_expression_type():
repn = generate_standard_repn(member - val)
if repn.is_linear() and len(repn.linear_vars) == 1:
# fix the value of the single variable
Expand All @@ -538,6 +534,9 @@ def pass_single_value(self, port, name, member, val, fixed):
"one free variable when trying to pass a value "
"to it. Please fix more variables before passing "
"to this port." % (name, port.name))
else:
fixed.add(member)
member.fix(val)

def source_dest_peer(self, arc, name, index=None):
"""
Expand Down

0 comments on commit dfbb6e6

Please sign in to comment.