Found a bug regarding the RemovedCharacterMutator where it doesn't re…

…move the first character in the name. (microsoft#296)
jpinz · Jan 18, 2022 · b872870 · b872870
1 parent e51b545
commit b872870
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/oss-find-squats-lib/Mutators/RemovedCharacterMutator.cs b/src/oss-find-squats-lib/Mutators/RemovedCharacterMutator.cs
@@ -13,7 +13,7 @@ public class RemovedCharacterMutator : IMutator
 
         public IEnumerable<Mutation> Generate(string arg)
         {
-            for (int i = 1; i < arg.Length; i++)
+            for (int i = 0; i < arg.Length; i++)
             {
                 yield return new Mutation(
                     mutated: $"{arg[..i]}{arg[(i + 1)..]}",

diff --git a/src/oss-tests/FindSquatsTests.cs b/src/oss-tests/FindSquatsTests.cs
@@ -35,7 +35,8 @@ public async Task DetectSquats(string packageUrl, bool expectedToHaveSquats)
         }
 
         [DataTestMethod]
-        [DataRow("pkg:npm/foo", "foojs")]
+        [DataRow("pkg:npm/foo", "foojs")] // SuffixAdded, js
+        [DataRow("pkg:npm/lodash", "odash")] // RemovedCharacter, first character
         [DataRow("pkg:nuget/Microsoft.CST.OAT", "microsoft.cst.oat.net")]
         public void GenerateManagerSpecific(string packageUrl, string expectedToFind)
         {