Skip to content

Commit

Permalink
Remove TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
cmbrose committed Jun 3, 2022
1 parent 2310795 commit ce3a132
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion internal/codespaces/ssh.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ func NewRemoteCommand(ctx context.Context, tunnelPort int, destination string, s
// newSSHCommand populates an exec.Cmd to run a command (or if blank,
// an interactive shell) over ssh.
func newSSHCommand(ctx context.Context, port int, dst string, cmdArgs []string) (*exec.Cmd, []string, error) {
// TODO: Read SSH key from ~/.ssh/codespace and pass as argument with -i
connArgs := []string{"-p", strconv.Itoa(port), "-o", "NoHostAuthenticationForLocalhost=yes"}

// The ssh command syntax is: ssh [flags] user@host command [args...]
Expand Down
1 change: 0 additions & 1 deletion internal/codespaces/states.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ func PollPostCreateStates(ctx context.Context, progress progressIndicator, apiCl

progress.StartProgressIndicatorWithLabel("Fetching SSH Details")
defer progress.StopProgressIndicator()
// TODO: This shouldn't care about the key
remoteSSHServerPort, sshUser, err := session.StartSSHServer(ctx)
if err != nil {
return fmt.Errorf("error getting ssh server details: %w", err)
Expand Down

0 comments on commit ce3a132

Please sign in to comment.