[test] Add faker.fake functional tests #386

- Now running all methods through faker.fake - Adds coverage for scope issues #376 - Refactors functional test methods to helper
jrenelg · Oct 27, 2018 · ad88ac3 · ad88ac3
1 parent ed9c560
commit ad88ac3
Show file tree

Hide file tree

Showing 3 changed files with 111 additions and 34 deletions.
diff --git a/test/all.functional.js b/test/all.functional.js
@@ -4,41 +4,9 @@ if (typeof module !== 'undefined') {
     var faker = require('../index');
 }
 
-var IGNORED_MODULES = ['locales', 'locale', 'localeFallback', 'definitions', 'fake', 'helpers'];
-var IGNORED_METHODS = {
-    system: ['directoryPath', 'filePath'] // these are TODOs
-};
+var functionalHelpers = require('./support/function-helpers.js');
 
-function isTestableModule(mod) {
-    return IGNORED_MODULES.indexOf(mod) === -1;
-}
-
-function isMethodOf(mod) {
-    return function(meth) {
-        return typeof faker[mod][meth] === 'function';
-    };
-}
-
-function isTestableMethod(mod) {
-    return function(meth) {
-        return !(mod in IGNORED_METHODS && IGNORED_METHODS[mod].indexOf(meth) >= 0);
-    };
-}
-
-function both(pred1, pred2) {
-    return function(value) {
-        return pred1(value) && pred2(value);
-    };
-}
-
-// Basic smoke tests to make sure each method is at least implemented and returns a value.
-
-var modules = Object.keys(faker)
-    .filter(isTestableModule)
-    .reduce(function(result, mod) {
-        result[mod] = Object.keys(faker[mod]).filter(both(isMethodOf(mod), isTestableMethod(mod)));
-        return result;
-    }, {});
+var modules = functionalHelpers.modulesList();
 
 describe("functional tests", function () {
   for(var locale in faker.locales) {
@@ -58,4 +26,30 @@ describe("functional tests", function () {
         });
     });
   }
+});
+
+describe("faker.fake functional tests", function () {
+  for(var locale in faker.locales) {
+    faker.locale = locale;
+    faker.seed(1);
+    Object.keys(modules).forEach(function (module) {
+        describe(module, function () {
+            modules[module].forEach(function (meth) {
+                it(meth + "()", function () {
+                    var result = faker.fake('{{' + module + '.' + meth + '}}');
+                    // just make sure any result is returned
+                    // an undefined result usually means an error
+                    assert.ok(typeof result !== 'undefined');
+                    /*
+                    if (meth === 'boolean') {
+                        assert.ok(result === true || result === false);
+                    } else {
+                        assert.ok(result);
+                    }
+                    */
+                });
+            });
+        });
+    });
+  }
 });
diff --git a/test/helpers.unit.js b/test/helpers.unit.js
@@ -52,13 +52,46 @@ describe("helpers.js", function () {
         });
     });
 
+    describe("mustache()", function () {
+        it("returns empty string with no arguments", function () {
+            assert.equal(faker.helpers.mustache(), "");
+        });
+    });
+
+    describe("repeatString()", function () {
+        it("returns empty string with no arguments", function () {
+            assert.equal(faker.helpers.repeatString(), "");
+        });
+    });
+
+    describe("replaceSymbols()", function () {
+        it("returns empty string with no arguments", function () {
+            assert.equal(faker.helpers.replaceSymbols(), "");
+        });
+    });
+
+    /*
+    describe("replaceCreditCardSymbols()", function () {
+        it("returns empty string with no arguments", function () {
+            assert.equal(faker.helpers.replaceCreditCardSymbols(), "");
+        });
+    });
+    */
+
     describe("createCard()", function () {
         it("returns an object", function () {
             var card = faker.helpers.createCard();
             assert.ok(typeof card === 'object');
         });
     });
 
+    describe("contextualCard()", function () {
+        it("returns an object", function () {
+            var card = faker.helpers.contextualCard();
+            assert.ok(typeof card === 'object');
+        });
+    });
+
     describe("userCard()", function () {
         it("returns an object", function () {
             var card = faker.helpers.userCard();

diff --git a/test/support/function-helpers.js b/test/support/function-helpers.js
@@ -0,0 +1,50 @@
+if (typeof module !== 'undefined') {
+    var assert = require('assert');
+    var sinon = require('sinon');
+    var faker = require('../../index');
+}
+
+var functionHelpers = {};
+
+module.exports = functionHelpers;
+
+
+var IGNORED_MODULES = ['locales', 'locale', 'localeFallback', 'definitions', 'fake', 'helpers'];
+var IGNORED_METHODS = {
+    system: ['directoryPath', 'filePath'] // these are TODOs
+};
+
+function isTestableModule(mod) {
+    return IGNORED_MODULES.indexOf(mod) === -1;
+}
+
+function isMethodOf(mod) {
+    return function(meth) {
+        return typeof faker[mod][meth] === 'function';
+    };
+}
+
+function isTestableMethod(mod) {
+    return function(meth) {
+        return !(mod in IGNORED_METHODS && IGNORED_METHODS[mod].indexOf(meth) >= 0);
+    };
+}
+
+function both(pred1, pred2) {
+    return function(value) {
+        return pred1(value) && pred2(value);
+    };
+}
+
+// Basic smoke tests to make sure each method is at least implemented and returns a value.
+
+functionHelpers.modulesList = function modulesList () {
+  var modules = Object.keys(faker)
+      .filter(isTestableModule)
+      .reduce(function(result, mod) {
+          result[mod] = Object.keys(faker[mod]).filter(both(isMethodOf(mod), isTestableMethod(mod)));
+          return result;
+      }, {});
+
+  return modules;
+}