Skip to content

Commit

Permalink
env: ext4: set gd->env_valid
Browse files Browse the repository at this point in the history
Add a missing initialization of gd->env_valid in env_ext4_load
as it is already done in some other env device.

Set gd->env_valid = ENV_VALID in env_ext4_save() and env_ext4_load().

This patch allows to have a correct information in 'env info' command.

Reviewed-by: Tom Rini <[email protected]>
Signed-off-by: Patrick Delaunay <[email protected]>
  • Loading branch information
patrickdelaunay authored and trini committed Jul 31, 2020
1 parent 87dac74 commit 286fee5
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion env/ext4.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
#include <ext4fs.h>
#include <mmc.h>

DECLARE_GLOBAL_DATA_PTR;

__weak const char *env_ext4_get_intf(void)
{
return (const char *)CONFIG_ENV_EXT4_INTERFACE;
Expand Down Expand Up @@ -79,6 +81,7 @@ static int env_ext4_save(void)
CONFIG_ENV_EXT4_FILE, ifname, dev, part);
return 1;
}
gd->env_valid = ENV_VALID;

puts("done\n");
return 0;
Expand Down Expand Up @@ -124,7 +127,11 @@ static int env_ext4_load(void)
goto err_env_relocate;
}

return env_import(buf, 1);
err = env_import(buf, 1);
if (!err)
gd->env_valid = ENV_VALID;

return err;

err_env_relocate:
env_set_default(NULL, 0);
Expand Down

0 comments on commit 286fee5

Please sign in to comment.