Merge pull request palantir#708 from palantir/yield

Yield expressions are valid standalone expressions
jrrbru · Oct 2, 2015 · 1784952 · 1784952
2 parents c233ab3 + e27f430
commit 1784952
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/rules/noUnusedExpressionRule.ts b/src/rules/noUnusedExpressionRule.ts
@@ -40,7 +40,7 @@ class UnusedExpressionWalker extends Lint.RuleWalker {
                 if (expressionText === "\"use strict\"" || expressionText === "'use strict'") {
                     return;
                 }
-            } else if (node.expression.kind === ts.SyntaxKind.DeleteExpression) {
+            } else if (node.expression.kind === ts.SyntaxKind.DeleteExpression || node.expression.kind === ts.SyntaxKind.YieldExpression) {
                 return;
             }
 

diff --git a/test/files/rules/unused.expression.test.ts b/test/files/rules/unused.expression.test.ts
@@ -48,3 +48,8 @@ a => fun2(a);
 
 var obj = {};
 delete obj.key;
+function* g(): Iterable<number> {
+    for (let i = 0; i < 100; i++) {
+        yield i;
+    }
+}
-Original file line number
+Diff line change
@@ Expand Up / @@ -40,7 +40,7 @@ class UnusedExpressionWalker extends Lint.RuleWalker { @@
                     if (expressionText === "\"use strict\"" || expressionText === "'use strict'") {
                         return;
                     }
-                } else if (node.expression.kind === ts.SyntaxKind.DeleteExpression) {
+                } else if (node.expression.kind === ts.SyntaxKind.DeleteExpression || node.expression.kind === ts.SyntaxKind.YieldExpression) {
                     return;
                 }
@@ Expand Down @@