Fir and format printf calls #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
em-er-es
commented
Mar 1, 2025
em-er-es
commented
- Fix printf lowercase typo
- Fix printf newline typo
- Fix errorf lowercase typos in config and journal
- Update changelog
Squash printf calls into one Fix error code for journal directory check
jrswab
requested changes
Mar 6, 2025
| fmt.Printf("Make sure the path is correct and the directories exist./n") | ||
| os.Exit(0) | ||
| fmt.Printf("Could not find Logseq files at '%s'.\nMake sure the path is correct and the directories exist.\n", cfg.DirPath) | ||
| os.Exit(1) |
There was a problem hiding this comment.
Good catch here with the switch to os.Exit(1).
| return nil, fmt.Errorf("error reading config file: %v\n", err) | ||
| return nil, fmt.Errorf("Error reading config file: %v\n", err) |
There was a problem hiding this comment.
It's Go convention to keep all error massages from starting with a capital letter. When you have the time please switch these back.
Comment on lines
+14
to
+16
| ### Fixed | ||
| - Printed calls and formatting | ||
|
|
There was a problem hiding this comment.
Move this into the [unreleased] section of the change log. I'll bump the version once I cut a new release.
There was a problem hiding this comment.
Make sure to revert line 10 back to ## [1.1.0] - 2025-02-16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.