websockets: Return from writer thread after close finished #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an interrupt arrived, the writer thread sends a CloseMessage, the reader thread receives confirmation and nicely shuts down, closing the done channel and the websocket. If that happens within one second, the writer thread needs to return rather than continuing in the loop. If that didn't happen within one second, only then it's useful for the writer thread to call c.Close() as well. The most important fix is changing break to return, to avoid leaking the writer thread and having it fail every second.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an interrupt arrived, the writer thread sends a CloseMessage, the reader thread receives confirmation and nicely shuts down, closing the done channel and the websocket. If that happens within one second, the writer thread needs to return rather than continuing in the loop. If that didn't happen within one second, only then it's useful for the writer thread to call c.Close() as well.
The most important fix is changing break to return, to avoid leaking the writer thread and having it fail every second.