Add GetInvitedFriends, RemoveInvitedFriend client functions

[mooseburgr]

closes #46

[mooseburgr]

FWIW, this is working in "prod" against my server v1.25.3.5409, as well as via local ad-hoc tests:
mooseburgr/plex-utils@4d0295d
https://plexy.vercel.app/

I wasn't sure what kind of tests you'd like, so I only added some minimal unit tests vs committing any integration tests. If the OS env variables are expected to work, I can definitely add back my integ test placeholders, let me know of any concerns @jrudio !

[jrudio]

Hey @mooseburgr, thanks for the PR. I looked it over and so far it reads well.

I am going to test manually. As for unit and integration test, I am still trying to figure out best practice for integration testing a client against an API. Any chance you have pointers or know of an example repository that does this?

I feel like if a unit tests passes with example data, but integration fails because PMS changed an endpoint response, why not just stick with an integration test? 😞 Maybe that's a bad thought process

To your question about OS env vars, master branch doesn't utilize those variables, but feature/cloud-build branch

go-plex-client/plex_test.go

Line 20 in be9ebdf

plexHost = os.Getenv("PLEX_HOST")

does, which I plan to work on... soon.

So if you do not want to commit those, that is fine.

[mooseburgr]

Ha nope, I totally agree! Mocking out any sort of actual response from the server is pretty useless for client SDK stuff like this, imo. Other than maybe de/serialization testing.

Ugh, I feel like maybe spinning up a disposable / test server via Docker would meet that need, but I have yet to try it. Plus that then requires Docker available on whatever device is running the integ tests, but that's not too terrible. I might play around with it locally at some point and throw something up, but no guarantees.

Otherwise I might poke around what you're doing in the cloud-build branch and see if there's something there I could help with in terms of setting up integ tests. 🤷

update: ah, nvm! I see you were already planning on spinning one up via Docker for integ tests!

[jrudio]

Sorry for the delay, just ran the pr manually and works fine for me.

Going to merge now!

[mooseburgr]

oh no problem! just happened to check in and noticed it was behind your master branch

[mooseburgr]

thank you so much!

[jrudio]

No problem! Thank you for the contribution!

…

On Fri, Mar 11, 2022 at 1:35 PM Kyle Johnson ***@***.***> wrote: thank you so much! — Reply to this email directly, view it on GitHub <#47 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABSSICL4PRWGCCWEB2SZJSDU7O4BPANCNFSM5NEWOUYQ> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>