Skip to content

Commit

Permalink
MDL-63346 travis: GRUNT job immune to npm-shrinkwrap.json changes
Browse files Browse the repository at this point in the history
When upgrading nodejs/npm versions, there are modifications to
different packages or to the format of the npm-shrinkwrap.json
file. Usually that leads to failed jobs untill the bundled file
is updated.

To avoid that, we just ignore the npm-shrinkwrap.json file, so
just the REAL modifications in css/js/ignore stuff are considered.
  • Loading branch information
stronk7 committed Sep 14, 2018
1 parent 674ef9b commit 83a548c
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,9 @@ script:
grunt ;
# Add all files to the git index and then run diff --cached to see all changes.
# This ensures that we get the status of all files, including new files.
# We ignore npm-shrinkwrap.json to make the tasks immune to npm changes.
git add . ;
git reset -- npm-shrinkwrap.json ;
git diff --cached --exit-code ;
fi
Expand Down

0 comments on commit 83a548c

Please sign in to comment.