chore: upgrade typescript and fix tests

.vscode/settings.json

@@ -1,4 +1,5 @@
 {
     "editor.formatOnSave": true,
     "javascript.format.enable": false,
+    "typescript.tsdk": "node_modules/typescript/lib",
 }

config/config.test.json

@@ -0,0 +1 @@
+{}

package.json

@@ -83,7 +83,7 @@
     "ts-jest": "^23.10.5",
     "ts-loader": "^5.3.3",
     "ts-node": "^8.10.1",
-    "typescript": "^3.2.2"
+    "typescript": "^3.9.3"
   },
   "jest": {
     "collectCoverageFrom": [
@@ -97,7 +97,7 @@
         "transform": {
           "^.+\\.tsx?$": "ts-jest"
         },
-        "testRegex": "(.*/views/.*)((test|spec))\\.(jsx?|tsx?)$",
+        "testRegex": "(.*/clients/.*)((test|spec))\\.(jsx?|tsx?)$",
         "moduleFileExtensions": [
           "ts",
           "tsx",
@@ -123,13 +123,14 @@
         "transform": {
           "^.+\\.tsx?$": "ts-jest"
         },
-        "testRegex": "(/__tests__/.*|(\\.|/)(test|spec))\\.(jsx?|tsx?)$",
+        "testRegex": "(.*/src/lib/.*)(/__tests__/.*|(\\.|/)(test|spec))\\.(jsx?|tsx?)$",
         "modulePathIgnorePatterns": [
           "<rootDir>/dist/"
         ],
         "testPathIgnorePatterns": [
           "/node_modules/",
-          "/views/"
+          "/views/",
+          "legacy"
         ],
         "moduleFileExtensions": [
           "ts",

src/clients/javascript/test/connect.test.ts

@@ -0,0 +1,76 @@
+import Pizzly from '../src/index'
+
+describe('Connect', () => {
+  beforeAll(() => {
+    window.addEventListener = jest.fn()
+    // @ts-ignore
+    window.open = jest.fn(() => {
+      return { closed: false }
+    })
+  })
+
+  const publishableKey = 'foo'
+  const integration = 'github'
+
+  function setup() {
+    return new Pizzly(publishableKey)
+  }
+
+  describe('connect', () => {
+    it('is a function', () => {
+      const pizzly = setup()
+
+      expect(pizzly.connect).toBeInstanceOf(Function)
+    })
+
+    it('accepts an integration argument', () => {
+      const pizzly = setup()
+
+      expect(pizzly.connect(integration)).toBeInstanceOf(Promise)
+    })
+
+    it('must have an integration argument', () => {
+      const pizzly = setup()
+      expect(() => {
+        // @ts-expect-error
+        return pizzly.connect()
+      }).toThrowError()
+    })
+
+    it('accepts an (optional) options argument', () => {
+      const pizzly = setup()
+
+      expect(pizzly.connect(integration, {})).toBeInstanceOf(Promise)
+    })
+  })
+
+  it('opens a popup (window modal)', () => {
+    const pizzly = setup()
+    expect.assertions(1)
+
+    pizzly.connect(integration).catch()
+
+    expect(window.open).toHaveBeenCalled()
+  })
+
+  // More tests to add on that:
+  // - it opens a popup with this URL
+  // - it opens a popup with this size
+  // - it opens a popup with this position
+
+  it('listens to message', () => {
+    const pizzly = setup()
+    expect.assertions(1)
+
+    pizzly.connect(integration).catch()
+
+    expect(window.addEventListener).toHaveBeenCalledWith('message', expect.any(Function), false)
+  })
+
+  describe('Return values', () => {
+    // More test to add here:
+    // it returns a promise
+    // it returns an object on promise.resolve
+    // it returns an error on promise.reject
+  })
+})

src/clients/javascript/test/initialization.test.js → src/clients/javascript/test/initialization.test.ts

@@ -1,4 +1,4 @@
-const Pizzly = require('../dist/index.umd.js')
+import Pizzly from '../src/index'
 
 describe('Pizzly class', () => {
   const publishableKey = 'foo'
@@ -13,6 +13,7 @@ describe('Pizzly class', () => {
 
     it('accepts no arguments', () => {
       expect(() => {
+        // @ts-expect-error
         new Pizzly()
       }).not.toThrowError()
     })
@@ -31,6 +32,7 @@ describe('Pizzly class', () => {
 
     it('accepts invalid options', () => {
       expect(() => {
+        // @ts-expect-error
         new Pizzly(publishableKey, invalidOptions)
       }).toBeInstanceOf(Function)
     })