Skip to content

Commit

Permalink
Cypress test cleanup
Browse files Browse the repository at this point in the history
This removes a couple repro tests that were being skipped and moves one of them to a proper scenario test (metabase#12689)
  • Loading branch information
dacort authored Jun 19, 2020
1 parent cf2ba24 commit 3c17fbf
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 85 deletions.
24 changes: 24 additions & 0 deletions frontend/test/metabase/scenarios/question/notebook.cy.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,30 @@ describe("scenarios > question > notebook", () => {
cy.contains("3");
});

it("should allow post-join filters (metabase#12221)", () => {
cy.log("start a custom question with Orders");
cy.visit("/question/new");
cy.contains("Custom question").click();
cy.contains("Sample Dataset").click();
cy.contains("Orders").click();

cy.log("join to People table using default settings");
cy.get(".Icon-join_left_outer ").click();
cy.contains("People").click();
cy.contains("Orders + People");
cy.contains("Visualize").click();
cy.contains("Showing first 2,000");

cy.log("attempt to filter on the joined table");
cy.contains("Filter").click();
cy.contains("Email").click();
cy.contains("People – Email");
cy.get('[placeholder="Search by Email"]').type("wolf.");
cy.contains("[email protected]").click();
cy.contains("Add filter").click();
cy.contains("Showing 1 row");
});

describe("nested", () => {
it("should create a nested question with post-aggregation filter", () => {
// start a custom question with orders
Expand Down
59 changes: 0 additions & 59 deletions frontend/test/metabase/support/date_field_filter.cy.spec.js

This file was deleted.

26 changes: 0 additions & 26 deletions frontend/test/metabase/support/join_filter.cy.spec.js

This file was deleted.

0 comments on commit 3c17fbf

Please sign in to comment.