Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jstzd): print banner and progress bar while launching #716

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

huancheng-trili
Copy link
Collaborator

@huancheng-trili huancheng-trili commented Dec 20, 2024

Context

Part of JSTZ-247.
JSTZ-247

Description

Print the jstz banner and a progress bar while jstzd is loading.

Manually testing the PR

Ran jstzd locally and observed the printed lines.

$ ./jstzd run /tmp/config.json 

           __________
           \  jstz  /
            )______(
            |""""""|_.-._,.---------.,_.-._
            |      | | |               | | ''-.
            |      |_| |_             _| |_..-'
            |______| '-' `'---------'` '-'
            )""""""(
           /________\
           `'------'`
         .------------.
        /______________\

        0.1.0-alpha.0 https://github.com/jstz-dev/jstz

⠁ [████████████████████░░░░░░░░░░░░░░░░░░░░]       2/4

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 71.05263% with 33 lines in your changes missing coverage. Please review.

Project coverage is 46.85%. Comparing base (91fb9ee) to head (2770eb8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/jstzd/src/task/jstzd.rs 67.02% 29 Missing and 2 partials ⚠️
crates/jstzd/src/lib.rs 90.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
crates/jstzd/src/lib.rs 56.09% <90.00%> (+33.37%) ⬆️
crates/jstzd/src/task/jstzd.rs 23.35% <67.02%> (+14.11%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91fb9ee...2770eb8. Read the comment docs.

@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-247-1 branch 5 times, most recently from 8ece474 to 2295cb7 Compare December 20, 2024 14:51
@huancheng-trili huancheng-trili marked this pull request as ready for review December 20, 2024 16:31
@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-247-1 branch from ba050e4 to 2295cb7 Compare December 30, 2024 12:47
Base automatically changed from huanchengchang-jstz-245 to main December 31, 2024 17:40
@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-247-1 branch from 2295cb7 to 2770eb8 Compare December 31, 2024 17:43
Copy link
Collaborator

@ryutamago ryutamago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@huancheng-trili huancheng-trili merged commit 402aa9b into main Jan 2, 2025
5 checks passed
@huancheng-trili huancheng-trili deleted the huanchengchang-jstz-247-1 branch January 2, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants