feat(jstz): use file wrapper for kernel debug log in config #735
+53
−47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Part of JSTZ-250.
JSTZ-250
Description
Use
FileWrapper
in jstz node config for kernel debug log.kernel_debug_file
does not get deserialised since we don't have any use case for that, so we don't need to implementDeserialize
forFileWrapper
. Overall, carrying a file like this in config is definitely not good because it complicates de/serialisation. There should be a refactor later on to get rid of all these whatever wrapper in config types and instead hold them somewhere else like in the jstzd state or so.Manually testing the PR