Skip to content

Commit

Permalink
Fix: don't restart autohttps on change to dynamic traefik config
Browse files Browse the repository at this point in the history
  • Loading branch information
consideRatio committed Apr 22, 2020
1 parent 10ad031 commit 2c66fff
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion jupyterhub/templates/proxy/autohttps/deployment.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{{- $HTTPS := (and .Values.proxy.https.hosts .Values.proxy.https.enabled) }}
{{- $autoHTTPS := (and $HTTPS (eq .Values.proxy.https.type "letsencrypt")) }}
{{- if $autoHTTPS -}}

apiVersion: apps/v1
kind: Deployment
metadata:
Expand All @@ -18,7 +19,11 @@ spec:
{{- include "jupyterhub.matchLabels" . | nindent 8 }}
hub.jupyter.org/network-access-proxy-http: "true"
annotations:
checksum/config-map: {{ include (print .Template.BasePath "/proxy/autohttps/configmap.yaml") . | sha256sum }}
# Only force a restart through a change to this checksum when the static
# configuration is changed, as the dynamic can be updated after start.
# Any disruptions to this deployment impacts everything, it is the
# entrypoint of all network traffic.
checksum/static-config: {{ include "jupyterhub.traefik.yaml" . | fromYaml | merge .Values.proxy.traefik.extraStaticConfig | toYaml | sha256sum }}
spec:
{{- if .Values.rbac.enabled }}
serviceAccountName: autohttps
Expand Down

0 comments on commit 2c66fff

Please sign in to comment.