Skip to content

Commit

Permalink
Remove group task and register zinc_compile directly
Browse files Browse the repository at this point in the history
GroupTask was only used by one task, and there was only one task left in the group.

This change has a side deffect of moving some path names used in the buildcache.

Testing Done:
CI is green at https://travis-ci.org/pantsbuild/pants/builds/95272210

Bugs closed: 2669

Reviewed at https://rbcommons.com/s/twitter/r/3215/
  • Loading branch information
ericzundel committed Dec 8, 2015
1 parent 4ec5c67 commit 8f50d7d
Show file tree
Hide file tree
Showing 13 changed files with 41 additions and 784 deletions.
15 changes: 0 additions & 15 deletions src/python/pants/backend/core/tasks/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ target(
':dependees',
':filemap',
':filter',
':group_task',
':list_owners',
':listtargets',
':markdown_to_html',
Expand Down Expand Up @@ -150,19 +149,6 @@ python_library(
],
)

python_library(
name = 'group_task',
sources = ['group_task.py'],
dependencies = [
'3rdparty/python:six',
'src/python/pants/base:workunit',
'src/python/pants/build_graph',
'src/python/pants/goal',
'src/python/pants/option',
'src/python/pants/task',
],
)

python_library(
name = 'listtargets',
sources = ['listtargets.py'],
Expand Down Expand Up @@ -230,7 +216,6 @@ python_library(
name = 'reflect',
sources = ['reflect.py'],
dependencies = [
':group_task',
'3rdparty/python:docutils',
'3rdparty/python:six',
'src/python/pants/base:build_environment',
Expand Down
Loading

0 comments on commit 8f50d7d

Please sign in to comment.