Adding code for finish box and stl files and blender files for printi… #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for: Issue jtulach#1- The time in event can be wrong.
jtulach
approved these changes
Nov 20, 2019
arduino/finishBox/finishBox.ino
Outdated
| unsigned long seconds = 0; | ||
| unsigned long milliSeconds = 0; | ||
| phone->getCurrentUnixTimeStamp(&seconds, &milliSeconds); | ||
| sprintf(cmd, "http://skimb.xelfi.cz/timing/add?when=%ld%03d&type=FINISHBOX_STARTED", seconds, milliSeconds); |
There was a problem hiding this comment.
I'd prefer type=FINISH_INITIALIZED.
| phone.getCurrentUnixTimeStamp(&seconds, &milliSeconds); | ||
| int size = sprintf(cmd, "http://skimb.xelfi.cz/timing/add?when=%ld%d&type=FINISH", seconds, milliSeconds); | ||
| phone->getCurrentUnixTimeStamp(&seconds, &milliSeconds); | ||
| int size = sprintf(cmd, "http://skimb.xelfi.cz/timing/add?when=%ld%03d&type=FINISH", seconds, milliSeconds); |
There was a problem hiding this comment.
You can save even more space by doing sharing the string:
sprintf(cmd, "http://skimb.xelfi.cz/timing?add?when%ld%03d&type=%s", seconds, milliSeconds, "FINISH");
sprintf(cmd, "http://skimb.xelfi.cz/timing?add?when%ld%03d&type=%s", seconds, milliSeconds, "FINISH_INITIALIZED");
arduino/startBox/startBox.ino
Outdated
| unsigned long seconds = 0; | ||
| unsigned long milliSeconds = 0; | ||
| phone->getCurrentUnixTimeStamp(&seconds, &milliSeconds); | ||
| sprintf_P(cmd, PSTR("http://skimb.xelfi.cz/timing/add?when=%ld%03d&type=STARTBOX_STARTED"), seconds, milliSeconds); |
There was a problem hiding this comment.
I prefer type=START_INITIALIZED.
| lcd->setCursor(0, 1); | ||
| lcd->print(F("Odstartovano")); | ||
| playStartMelody(); | ||
| sprintf_P(cmd, PSTR("http://skimb.xelfi.cz/timing/add?when=%ld%03d&type=START"), seconds, milliSeconds); |
There was a problem hiding this comment.
Again, it might save some memory using %s for the type. Possibly this could even be made a helper utilitity in Phone as all the URL connections are the same.
| delay(BREAK_AFTER_SENDING); | ||
| lcd->setCursor(0, 2); | ||
| lcd->print(F("Posilani casu startu")); | ||
| phone->sendRequest(cmd); |
There was a problem hiding this comment.
This would be phone->sendRequest(type, seconds, milliSeconds)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding recent code for finish box and also stl files and blender files for printing boxes