Skip to content

Commit

Permalink
xace: fix access mode in dixLookupWindow within several RandR calls.
Browse files Browse the repository at this point in the history
Referencing a screen using a window only requires GetAttr access.

Signed-off-by: Eamon Walsh <[email protected]>
  • Loading branch information
Eamon Walsh committed Aug 17, 2009
1 parent d4b8f76 commit 4098ad7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion randr/rrmode.c
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ ProcRRCreateMode (ClientPtr client)
RRModePtr mode;

REQUEST_AT_LEAST_SIZE (xRRCreateModeReq);
rc = dixLookupWindow(&pWin, stuff->window, client, DixReadAccess);
rc = dixLookupWindow(&pWin, stuff->window, client, DixGetAttrAccess);
if (rc != Success)
return rc;

Expand Down
8 changes: 4 additions & 4 deletions randr/rrscreen.c
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ ProcRRGetScreenSizeRange (ClientPtr client)
int rc;

REQUEST_SIZE_MATCH(xRRGetScreenInfoReq);
rc = dixLookupWindow(&pWin, stuff->window, client, DixReadAccess);
rc = dixLookupWindow(&pWin, stuff->window, client, DixGetAttrAccess);
if (rc != Success)
return rc;

Expand Down Expand Up @@ -261,7 +261,7 @@ ProcRRSetScreenSize (ClientPtr client)
int i, rc;

REQUEST_SIZE_MATCH(xRRSetScreenSizeReq);
rc = dixLookupWindow(&pWin, stuff->window, client, DixReadAccess);
rc = dixLookupWindow(&pWin, stuff->window, client, DixGetAttrAccess);
if (rc != Success)
return rc;

Expand Down Expand Up @@ -331,7 +331,7 @@ rrGetScreenResources(ClientPtr client, Bool query)
CARD8 *names;

REQUEST_SIZE_MATCH(xRRGetScreenResourcesReq);
rc = dixLookupWindow(&pWin, stuff->window, client, DixReadAccess);
rc = dixLookupWindow(&pWin, stuff->window, client, DixGetAttrAccess);
if (rc != Success)
return rc;

Expand Down Expand Up @@ -606,7 +606,7 @@ ProcRRGetScreenInfo (ClientPtr client)
RROutputPtr output;

REQUEST_SIZE_MATCH(xRRGetScreenInfoReq);
rc = dixLookupWindow(&pWin, stuff->window, client, DixReadAccess);
rc = dixLookupWindow(&pWin, stuff->window, client, DixGetAttrAccess);
if (rc != Success)
return rc;

Expand Down

0 comments on commit 4098ad7

Please sign in to comment.