Skip to content

Commit

Permalink
pinctrl: zynqmp: Revert "Unify pin naming"
Browse files Browse the repository at this point in the history
This reverts commit 54784ff.

This patch changes the pin names from "MIO%d" to "MIO-%d", but all dts
in arch/arm64/boot/dts/xilinx still use the old name. As a result my
ZCU104 has no output on serial terminal and is not reachable over
network.

Signed-off-by: Gerhard Engleder <[email protected]>
Signed-off-by: Andy Shevchenko <[email protected]>
  • Loading branch information
Gerhard Engleder authored and andy-shev committed Jan 28, 2022
1 parent e12963c commit 500c77e
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions drivers/pinctrl/pinctrl-zynqmp.c
Original file line number Diff line number Diff line change
Expand Up @@ -809,7 +809,6 @@ static int zynqmp_pinctrl_prepare_pin_desc(struct device *dev,
unsigned int *npins)
{
struct pinctrl_pin_desc *pins, *pin;
char **pin_names;
int ret;
int i;

Expand All @@ -821,14 +820,13 @@ static int zynqmp_pinctrl_prepare_pin_desc(struct device *dev,
if (!pins)
return -ENOMEM;

pin_names = devm_kasprintf_strarray(dev, ZYNQMP_PIN_PREFIX, *npins);
if (IS_ERR(pin_names))
return PTR_ERR(pin_names);

for (i = 0; i < *npins; i++) {
pin = &pins[i];
pin->number = i;
pin->name = pin_names[i];
pin->name = devm_kasprintf(dev, GFP_KERNEL, "%s%d",
ZYNQMP_PIN_PREFIX, i);
if (!pin->name)
return -ENOMEM;
}

*zynqmp_pins = pins;
Expand Down

0 comments on commit 500c77e

Please sign in to comment.