Fix custom theme color setting in config panel (CTFd#1268)

* Properly update the theme header with custom theme color values * Closes CTFd#1263
juliourena · Feb 29, 2020 · e764bb1 · e764bb1
1 parent 2f46f61
commit e764bb1
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/CTFd/themes/admin/assets/js/pages/configs.js b/CTFd/themes/admin/assets/js/pages/configs.js
@@ -245,18 +245,20 @@ $(() => {
   $(".nav-pills a").click(showTab);
   $("#config-color-update").click(function() {
     const hex_code = $("#config-color-picker").val();
-    const user_css = $("#css-editor").val();
+    const user_css = $("#theme-header").val();
     let new_css;
-    if (user_css.lenth) {
+    if (user_css.length) {
       let css_vars = `theme-color: ${hex_code};`;
       new_css = user_css.replace(/theme-color: (.*);/, css_vars);
     } else {
       new_css =
+        `<style id="theme-color">\n` +
         `:root {--theme-color: ${hex_code};}\n` +
         `.navbar{background-color: var(--theme-color) !important;}\n` +
-        `.jumbotron{background-color: var(--theme-color) !important;}\n`;
+        `.jumbotron{background-color: var(--theme-color) !important;}\n` +
+        `</style>\n`;
     }
-    $("#css-editor").val(new_css);
+    $("#theme-header").val(new_css);
   });
 
   $(".start-date").change(function() {