Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #318

Merged
merged 13 commits into from
Feb 25, 2025
Merged

Cleanup #318

merged 13 commits into from
Feb 25, 2025

Conversation

eveld
Copy link
Contributor

@eveld eveld commented Feb 23, 2025

  • Remove gvm
  • Replace any deprecated code with its replacement
  • Fix any staticcheck complaints
  • replace xerrors and old error patterns

@eveld eveld changed the base branch from main to erik/add-default-network February 23, 2025 07:21
@eveld eveld changed the title Address all staticcheck complaints Cleanup Feb 23, 2025
Copy link
Contributor

@nicholasjackson nicholasjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record I feel extremely uncomfortable approving this

@nicholasjackson nicholasjackson merged commit d24f5cf into erik/add-default-network Feb 25, 2025
24 checks passed
@eveld
Copy link
Contributor Author

eveld commented Feb 25, 2025

It was at gunpoint that he approved it, just fyi

@nicholasjackson
Copy link
Contributor

nicholasjackson commented Feb 25, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants