-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DSL for effect creation and composition #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d2d0fb2
to
3d5d87c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new DSL feature that allows effects to be created and composed using a string-based syntax, in appearance identical to (a tiny subset of) rust. The DSL makes ad-hoc runtime effect debugging/iteration feasible, plus is a pretty neat serialization format.
New Public API
Core Types
EffectDsl
: Reusable registry and compiler for effect expressionsDslCompiler
: Produces effects from input DSL. Single use.EffectExpression
: Parsed representation of a DSL expression (typically produced byEffect::to_dsl
)DslError
: Error types for DSL parsing and evaluationShader::to_dsl
: (optional) required for serializing effects to DSL strings.DslFormat
: Helper trait for converting types to DSL representationKey Functions
Features
Pretty-printing of DSL expressionsExamples (tachyonfx DSL)
Basic Effect
Complex composition
The DSL, while limited in scope, has bindings and parsers for the more frequently used types and methods.
(The DSL above is valid rust code too, in case it wasn't obvious)
Implementation notes
todo
let
assignmentsthe future