Skip to content

Commit

Permalink
git-remote: fix missing .uploadpack usage for show command
Browse files Browse the repository at this point in the history
For users pulling from machines with self compiled git installs,
in non-PATH locations, they can set the config option
remote.<name>.uploadpack to set the location of git-upload-pack.

When using 'git remote show <name>', the remote HEAD check
did not use the uploadpack configuration setting, and would
not use the configured program.

In builtin-remote.c, the config setting is already loaded
with the call to remote_get(), so this patch passes that remote
along to transport_get().

Signed-off-by: Chris Frey <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
  • Loading branch information
cdfrey authored and gitster committed Jun 25, 2009
1 parent 6651c3f commit 345a380
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion builtin-remote.c
Original file line number Diff line number Diff line change
Expand Up @@ -789,7 +789,7 @@ static int get_remote_ref_states(const char *name,
read_branches();

if (query) {
transport = transport_get(NULL, states->remote->url_nr > 0 ?
transport = transport_get(states->remote, states->remote->url_nr > 0 ?
states->remote->url[0] : NULL);
remote_refs = transport_get_remote_refs(transport);
transport_disconnect(transport);
Expand Down

0 comments on commit 345a380

Please sign in to comment.