Fix jobs list and refetching

justinian336 · Mar 4, 2016 · 5dab7fd · 5dab7fd
1 parent a173ddf
commit 5dab7fd
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/common/app/routes/Jobs/components/Jobs.jsx b/common/app/routes/Jobs/components/Jobs.jsx
@@ -32,7 +32,7 @@ const bindableActions = {
 const fetchOptions = {
   fetchAction: 'fetchJobs',
   isPrimed({ jobs }) {
-    return !!jobs.length;
+    return jobs.length > 1;
   }
 };
 

diff --git a/common/app/routes/Jobs/redux/fetch-jobs-saga.js b/common/app/routes/Jobs/redux/fetch-jobs-saga.js
@@ -16,7 +16,7 @@ export default ({ services }) => ({ dispatch }) => next => {
     const { payload: id } = action;
     const data = { service: 'jobs' };
     if (id) {
-      data.id = id;
+      data.params = { id };
     }
 
     return services.readService$(data)

diff --git a/server/services/job.js b/server/services/job.js
@@ -23,17 +23,20 @@ export default function getJobServices(app) {
       });
 
       Job.create(job, (err, savedJob) => {
-        cb(err, savedJob);
+        cb(err, savedJob.toJSON());
       });
     },
     read(req, resource, params, config, cb) {
       const id = params ? params.id : null;
+      console.log('params', params);
       if (id) {
-        return Job.findById(id, cb);
+        return Job.findById(id)
+          .then(job => cb(null, job.toJSON()))
+          .catch(cb);
       }
-      Job.find(whereFilt, (err, jobs) => {
-        cb(err, jobs.map(job => job.toJSON()));
-      });
+      Job.find(whereFilt)
+        .then(jobs => cb(null, jobs.map(job => job.toJSON())))
+        .catch(cb);
     }
   };
 }