Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yeoman upgrade to v1.x #46

Merged
merged 3 commits into from
Mar 26, 2017
Merged

Conversation

caroso1222
Copy link
Contributor

This PR addresses #37. It uses a class instead of an object to scaffold the library.

@caroso1222
Copy link
Contributor Author

PR seems to be failing in Travis because of Parsing error: The keyword 'class' is reserved. I'm not experienced in Travis, but It might be due to .eslintrc being outdated or something.

@jvandemo
Copy link
Owner

jvandemo commented Mar 4, 2017

@caroso1222 — Thank you, this is awesome. I will try your changes locally and report back. Thanks for your great work!

@jvandemo jvandemo merged commit 891e7d3 into jvandemo:master Mar 26, 2017
@jvandemo
Copy link
Owner

Changes have been merged and released as v6.0.0.

Thank you for your contribution, @caroso1222 👍

@caroso1222 caroso1222 deleted the yeoman-upgrade branch April 17, 2017 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants