Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(umd): add support to generate UMD bundle #84

Merged
merged 6 commits into from
May 9, 2017
Merged

feat(umd): add support to generate UMD bundle #84

merged 6 commits into from
May 9, 2017

Conversation

jvandemo
Copy link
Owner

@jvandemo jvandemo commented May 8, 2017

This PR adds the ability to generate a UMD bundle for the library.

A UMD bundle can be used in Node.js, with SystemJS or as a script tag (e.g. with Plunker, Fiddle, etc).

@jvandemo
Copy link
Owner Author

jvandemo commented May 8, 2017

Looking for some testers to see if UMD bundle generation is working as expected.

@caroso1222, @jdjuan Would you be interested in testing this feature? Thanks in advance!

@jdjuan
Copy link
Collaborator

jdjuan commented May 8, 2017

@jvandemo will do so tomorrow 💪. Thanks for this PR!

@jvandemo
Copy link
Owner Author

jvandemo commented May 9, 2017

@jdjuan — Thank you, much appreciated! 👍

@jvandemo jvandemo merged commit 3e08fe3 into master May 9, 2017
@jvandemo jvandemo deleted the feat/umd branch May 9, 2017 06:56
@jdjuan
Copy link
Collaborator

jdjuan commented May 10, 2017

Hey @jvandemo really sorry for taking too long to test this 😅 I didn't quite know how to do it. I still don't. But I guess since you published you are fully sure it works, I will try to be faster next time 😅

@jvandemo
Copy link
Owner Author

@jdjuan — No problem at all, please don't apologize. I already appreciate a lot what you are doing to help this generator forward.

I had to merge early because people were waiting for this feature and I have a busy week so I won't always have the time to follow up before or after work.

Also, I'm suspecting it should behave fine on Windows and Linux as it uses the standard gulp plugins and nothing exotic was added.

If it doesn't, I'm sure people will take the effort to log issues.

Thanks again for your help and follow-up! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants